When AIFF to WAV, ReplayGain is not extracted as Side data.

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

When AIFF to WAV, ReplayGain is not extracted as Side data.

yas tam
When AIFF to WAV, ReplayGain is not extracted as Side data.
ReplayGain is correctly extracted as Side data when Flac to WAV or Apple
Lossless (m4a) to WAV.

    Side data:
      replaygain: track gain - -10.880000, track peak - 0.000023, album
gain - -10.880000, album peak - 0.000023,



How can I extract ReplayGain as Side data when using AIFF to WAV?

AIFF, Flac, Apple Lossless (m4a), I attach the logs when converted each to
WAV.

_______________________________________________
ffmpeg-user mailing list
[hidden email]
https://ffmpeg.org/mailman/listinfo/ffmpeg-user

To unsubscribe, visit link above, or email
[hidden email] with subject "unsubscribe".

aiff_to_wav.txt (5K) Download Attachment
flac_to_wav.txt (5K) Download Attachment
m4a_to_wav.txt (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: When AIFF to WAV, ReplayGain is not extracted as Side data.

Moritz Barsnick
On Tue, Mar 12, 2019 at 17:14:21 +0900, yas tam wrote:
> When AIFF to WAV, ReplayGain is not extracted as Side data.
> ReplayGain is correctly extracted as Side data when Flac to WAV or Apple
> Lossless (m4a) to WAV.

As far as I can tell, exporting replaygain as side data isn't
implemented for AIFF. aiff_read_header() is probably just missing a
call to ff_replaygain_export().

Moritz
_______________________________________________
ffmpeg-user mailing list
[hidden email]
https://ffmpeg.org/mailman/listinfo/ffmpeg-user

To unsubscribe, visit link above, or email
[hidden email] with subject "unsubscribe".
Reply | Threaded
Open this post in threaded view
|

Re: When AIFF to WAV, ReplayGain is not extracted as Side data.

yas tam
Hi Moritz,

Who should I ask about fix for adding ff_replaygain_export() to
aiff_read_header()?
Should I ask questions on the libav-user mailing list?

2019年3月12日(火) 18:02 Moritz Barsnick <[hidden email]>:

> On Tue, Mar 12, 2019 at 17:14:21 +0900, yas tam wrote:
> > When AIFF to WAV, ReplayGain is not extracted as Side data.
> > ReplayGain is correctly extracted as Side data when Flac to WAV or Apple
> > Lossless (m4a) to WAV.
>
> As far as I can tell, exporting replaygain as side data isn't
> implemented for AIFF. aiff_read_header() is probably just missing a
> call to ff_replaygain_export().
>
> Moritz
> _______________________________________________
> ffmpeg-user mailing list
> [hidden email]
> https://ffmpeg.org/mailman/listinfo/ffmpeg-user
>
> To unsubscribe, visit link above, or email
> [hidden email] with subject "unsubscribe".
_______________________________________________
ffmpeg-user mailing list
[hidden email]
https://ffmpeg.org/mailman/listinfo/ffmpeg-user

To unsubscribe, visit link above, or email
[hidden email] with subject "unsubscribe".
Reply | Threaded
Open this post in threaded view
|

Re: When AIFF to WAV, ReplayGain is not extracted as Side data.

Moritz Barsnick
On Tue, Mar 12, 2019 at 19:33:48 +0900, yas tam wrote:
> Who should I ask about fix for adding ff_replaygain_export() to
> aiff_read_header()?
> Should I ask questions on the libav-user mailing list?

No, the libav-user mailing list handles the use of the libav* libraries
through their APIs and ABIs.

You would post a ticket as an enhancement request at
https://trac.ffmpeg.org/.

I tried modifying this myself, but I was incapable of creating an AIFF
sample with replaygain metadata to test with (ffmpeg doesn't seem to
map arbitrary metadata into AIFF ID3v2). Can you provide a link to a
sample AIFF file with replaygain?

If I succeed, I can post the change to the appropriate mailing list for
review (if no-one gets to it before me).

Cheers,
Moritz
_______________________________________________
ffmpeg-user mailing list
[hidden email]
https://ffmpeg.org/mailman/listinfo/ffmpeg-user

To unsubscribe, visit link above, or email
[hidden email] with subject "unsubscribe".
Reply | Threaded
Open this post in threaded view
|

Re: When AIFF to WAV, ReplayGain is not extracted as Side data.

yas tam
Thanks Moritz.

I uploaded the sample file of AIFF with ReplayGain.
I also uploaded Flac file and Apple Lossless file of the same sound source.

https://www.dropbox.com/sh/zk3l8sn69zo2skc/AACgAyNqfgW2Pdsob90R7MBva?dl=0

※ These sound sources were created from free samples of 2L High Resolution
Music.
http://www.2l.no/hires/

Regards,


2019年3月13日(水) 1:24 Moritz Barsnick <[hidden email]>:

> On Tue, Mar 12, 2019 at 19:33:48 +0900, yas tam wrote:
> > Who should I ask about fix for adding ff_replaygain_export() to
> > aiff_read_header()?
> > Should I ask questions on the libav-user mailing list?
>
> No, the libav-user mailing list handles the use of the libav* libraries
> through their APIs and ABIs.
>
> You would post a ticket as an enhancement request at
> https://trac.ffmpeg.org/.
>
> I tried modifying this myself, but I was incapable of creating an AIFF
> sample with replaygain metadata to test with (ffmpeg doesn't seem to
> map arbitrary metadata into AIFF ID3v2). Can you provide a link to a
> sample AIFF file with replaygain?
>
> If I succeed, I can post the change to the appropriate mailing list for
> review (if no-one gets to it before me).
>
> Cheers,
> Moritz
> _______________________________________________
> ffmpeg-user mailing list
> [hidden email]
> https://ffmpeg.org/mailman/listinfo/ffmpeg-user
>
> To unsubscribe, visit link above, or email
> [hidden email] with subject "unsubscribe".
_______________________________________________
ffmpeg-user mailing list
[hidden email]
https://ffmpeg.org/mailman/listinfo/ffmpeg-user

To unsubscribe, visit link above, or email
[hidden email] with subject "unsubscribe".
Reply | Threaded
Open this post in threaded view
|

Re: When AIFF to WAV, ReplayGain is not extracted as Side data.

Moritz Barsnick
On Wed, Mar 13, 2019 at 12:30:16 +0900, yas tam wrote:
> I uploaded the sample file of AIFF with ReplayGain.
> I also uploaded Flac file and Apple Lossless file of the same sound source.
>
> https://www.dropbox.com/sh/zk3l8sn69zo2skc/AACgAyNqfgW2Pdsob90R7MBva?dl=0

Nice, thanks!

I have posted a proposed patch to the ffmpeg development mailing list:
http://ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241033.html

It works for me with your provided AIFF file - I can now see the
sidedata displayed for the input file, and the volume filter takes
effect when used with "-af volume=replaygain=track".

If you build your own ffmpeg from source, you can apply that patch and
try for yourself. Otherwise wait and see whether the maintainers accept
it.

Cheers,
Moritz
_______________________________________________
ffmpeg-user mailing list
[hidden email]
https://ffmpeg.org/mailman/listinfo/ffmpeg-user

To unsubscribe, visit link above, or email
[hidden email] with subject "unsubscribe".
Reply | Threaded
Open this post in threaded view
|

Re: When AIFF to WAV, ReplayGain is not extracted as Side data.

yas tam
Thank you for posted patch.
I applied that patch to source code and built them.
It works perfectly. Great!
ReplayGain works correctly when decoding AIFF with FFmpeg.
Thank you from the bottom of my heart.


2019年3月13日(水) 18:31 Moritz Barsnick <[hidden email]>:

> On Wed, Mar 13, 2019 at 12:30:16 +0900, yas tam wrote:
> > I uploaded the sample file of AIFF with ReplayGain.
> > I also uploaded Flac file and Apple Lossless file of the same sound
> source.
> >
> >
> https://www.dropbox.com/sh/zk3l8sn69zo2skc/AACgAyNqfgW2Pdsob90R7MBva?dl=0
>
> Nice, thanks!
>
> I have posted a proposed patch to the ffmpeg development mailing list:
> http://ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241033.html
>
> It works for me with your provided AIFF file - I can now see the
> sidedata displayed for the input file, and the volume filter takes
> effect when used with "-af volume=replaygain=track".
>
> If you build your own ffmpeg from source, you can apply that patch and
> try for yourself. Otherwise wait and see whether the maintainers accept
> it.
>
> Cheers,
> Moritz
> _______________________________________________
> ffmpeg-user mailing list
> [hidden email]
> https://ffmpeg.org/mailman/listinfo/ffmpeg-user
>
> To unsubscribe, visit link above, or email
> [hidden email] with subject "unsubscribe".
_______________________________________________
ffmpeg-user mailing list
[hidden email]
https://ffmpeg.org/mailman/listinfo/ffmpeg-user

To unsubscribe, visit link above, or email
[hidden email] with subject "unsubscribe".