Best place for despill filter?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

Best place for despill filter?

Michael Koch
When I overlay a bluescreen foreground video over a background video,
which is the best place for the despill filter? (a) before colorkey or
(b) after colorkey or (c) after overlay?

[foreground](a),colorkey,(b)[fg];[background][fg]overlay,(c)

I found here an example for (c) but I doubt that this makes sense:
https://gist.github.com/kerbeh/fbe0cd0d89c424708c119e0a0d00ca88

Michael

_______________________________________________
ffmpeg-user mailing list
[hidden email]
https://ffmpeg.org/mailman/listinfo/ffmpeg-user

To unsubscribe, visit link above, or email
[hidden email] with subject "unsubscribe".
Reply | Threaded
Open this post in threaded view
|

Re: Best place for despill filter?

Paul B Mahol
On Mon, Nov 16, 2020 at 12:13 PM Michael Koch <[hidden email]>
wrote:

> When I overlay a bluescreen foreground video over a background video,
> which is the best place for the despill filter? (a) before colorkey or
> (b) after colorkey or (c) after overlay?
>
> [foreground](a),colorkey,(b)[fg];[background][fg]overlay,(c)
>
> I found here an example for (c) but I doubt that this makes sense:
> https://gist.github.com/kerbeh/fbe0cd0d89c424708c119e0a0d00ca88
>
>
Why do you doubt that it does make sense?


> Michael
>
> _______________________________________________
> ffmpeg-user mailing list
> [hidden email]
> https://ffmpeg.org/mailman/listinfo/ffmpeg-user
>
> To unsubscribe, visit link above, or email
> [hidden email] with subject "unsubscribe".
_______________________________________________
ffmpeg-user mailing list
[hidden email]
https://ffmpeg.org/mailman/listinfo/ffmpeg-user

To unsubscribe, visit link above, or email
[hidden email] with subject "unsubscribe".
Reply | Threaded
Open this post in threaded view
|

Re: Best place for despill filter?

Michael Koch
Am 16.11.2020 um 12:22 schrieb Paul B Mahol:

> On Mon, Nov 16, 2020 at 12:13 PM Michael Koch <[hidden email]>
> wrote:
>
>> When I overlay a bluescreen foreground video over a background video,
>> which is the best place for the despill filter? (a) before colorkey or
>> (b) after colorkey or (c) after overlay?
>>
>> [foreground](a),colorkey,(b)[fg];[background][fg]overlay,(c)
>>
>> I found here an example for (c) but I doubt that this makes sense:
>> https://gist.github.com/kerbeh/fbe0cd0d89c424708c119e0a0d00ca88
>>
>>
> Why do you doubt that it does make sense?

I doubt that (c) is the right place because at position (c) the despill
filter also affects the background video, which surely doesn't have any
contamination from the bluescreen.

Michael

_______________________________________________
ffmpeg-user mailing list
[hidden email]
https://ffmpeg.org/mailman/listinfo/ffmpeg-user

To unsubscribe, visit link above, or email
[hidden email] with subject "unsubscribe".
Reply | Threaded
Open this post in threaded view
|

Re: Best place for despill filter?

Paul B Mahol
On Mon, Nov 16, 2020 at 12:41 PM Michael Koch <[hidden email]>
wrote:

> Am 16.11.2020 um 12:22 schrieb Paul B Mahol:
> > On Mon, Nov 16, 2020 at 12:13 PM Michael Koch <
> [hidden email]>
> > wrote:
> >
> >> When I overlay a bluescreen foreground video over a background video,
> >> which is the best place for the despill filter? (a) before colorkey or
> >> (b) after colorkey or (c) after overlay?
> >>
> >> [foreground](a),colorkey,(b)[fg];[background][fg]overlay,(c)
> >>
> >> I found here an example for (c) but I doubt that this makes sense:
> >> https://gist.github.com/kerbeh/fbe0cd0d89c424708c119e0a0d00ca88
> >>
> >>
> > Why do you doubt that it does make sense?
>
> I doubt that (c) is the right place because at position (c) the despill
> filter also affects the background video, which surely doesn't have any
> contamination from the bluescreen.
>

Then use it after colorkey.


>
> Michael
>
> _______________________________________________
> ffmpeg-user mailing list
> [hidden email]
> https://ffmpeg.org/mailman/listinfo/ffmpeg-user
>
> To unsubscribe, visit link above, or email
> [hidden email] with subject "unsubscribe".
_______________________________________________
ffmpeg-user mailing list
[hidden email]
https://ffmpeg.org/mailman/listinfo/ffmpeg-user

To unsubscribe, visit link above, or email
[hidden email] with subject "unsubscribe".
Reply | Threaded
Open this post in threaded view
|

Re: Best place for despill filter?

Michael Koch
Am 16.11.2020 um 16:12 schrieb Paul B Mahol:

> On Mon, Nov 16, 2020 at 12:41 PM Michael Koch <[hidden email]>
> wrote:
>
>> Am 16.11.2020 um 12:22 schrieb Paul B Mahol:
>>> On Mon, Nov 16, 2020 at 12:13 PM Michael Koch <
>> [hidden email]>
>>> wrote:
>>>
>>>> When I overlay a bluescreen foreground video over a background video,
>>>> which is the best place for the despill filter? (a) before colorkey or
>>>> (b) after colorkey or (c) after overlay?
>>>>
>>>> [foreground](a),colorkey,(b)[fg];[background][fg]overlay,(c)
>>>>
>>>> I found here an example for (c) but I doubt that this makes sense:
>>>> https://gist.github.com/kerbeh/fbe0cd0d89c424708c119e0a0d00ca88
>>>>
>>>>
>>> Why do you doubt that it does make sense?
>> I doubt that (c) is the right place because at position (c) the despill
>> filter also affects the background video, which surely doesn't have any
>> contamination from the bluescreen.
>>
> Then use it after colorkey.

Thank you, you confirmed what I also thought is the best place for the
despill filter. But I wasn't sure.
Might be a good idea to add a short note to the documentation of the
despill filter.

Michael

_______________________________________________
ffmpeg-user mailing list
[hidden email]
https://ffmpeg.org/mailman/listinfo/ffmpeg-user

To unsubscribe, visit link above, or email
[hidden email] with subject "unsubscribe".
Reply | Threaded
Open this post in threaded view
|

Re: Best place for despill filter?

Michael Koch
In reply to this post by Paul B Mahol
Am 16.11.2020 um 16:12 schrieb Paul B Mahol:

> On Mon, Nov 16, 2020 at 12:41 PM Michael Koch <[hidden email]>
> wrote:
>
>> Am 16.11.2020 um 12:22 schrieb Paul B Mahol:
>>> On Mon, Nov 16, 2020 at 12:13 PM Michael Koch <
>> [hidden email]>
>>> wrote:
>>>
>>>> When I overlay a bluescreen foreground video over a background video,
>>>> which is the best place for the despill filter? (a) before colorkey or
>>>> (b) after colorkey or (c) after overlay?
>>>>
>>>> [foreground](a),colorkey,(b)[fg];[background][fg]overlay,(c)
>>>>
>>>> I found here an example for (c) but I doubt that this makes sense:
>>>> https://gist.github.com/kerbeh/fbe0cd0d89c424708c119e0a0d00ca88
>>>>
>>>>
>>> Why do you doubt that it does make sense?
>> I doubt that (c) is the right place because at position (c) the despill
>> filter also affects the background video, which surely doesn't have any
>> contamination from the bluescreen.
>>
> Then use it after colorkey.

Is it possible to send zmq messages to the despill filter? I want to
adjust the mix, expand and brightness parameters in real time. I'm
sending the zmq messages from my own C# program. Messages to colorkey
(color, similarity) and overlay (x, y) are already working. When I send
messages to the despill filter, there is no error message but nothing
changes in the output video. Either I have something wrong in my code,
or the despill filter doesn't use the new values.

Michael

_______________________________________________
ffmpeg-user mailing list
[hidden email]
https://ffmpeg.org/mailman/listinfo/ffmpeg-user

To unsubscribe, visit link above, or email
[hidden email] with subject "unsubscribe".
Reply | Threaded
Open this post in threaded view
|

Re: Best place for despill filter?

Paul B Mahol
On Mon, Nov 16, 2020 at 7:45 PM Michael Koch <[hidden email]>
wrote:

> Am 16.11.2020 um 16:12 schrieb Paul B Mahol:
> > On Mon, Nov 16, 2020 at 12:41 PM Michael Koch <
> [hidden email]>
> > wrote:
> >
> >> Am 16.11.2020 um 12:22 schrieb Paul B Mahol:
> >>> On Mon, Nov 16, 2020 at 12:13 PM Michael Koch <
> >> [hidden email]>
> >>> wrote:
> >>>
> >>>> When I overlay a bluescreen foreground video over a background video,
> >>>> which is the best place for the despill filter? (a) before colorkey or
> >>>> (b) after colorkey or (c) after overlay?
> >>>>
> >>>> [foreground](a),colorkey,(b)[fg];[background][fg]overlay,(c)
> >>>>
> >>>> I found here an example for (c) but I doubt that this makes sense:
> >>>> https://gist.github.com/kerbeh/fbe0cd0d89c424708c119e0a0d00ca88
> >>>>
> >>>>
> >>> Why do you doubt that it does make sense?
> >> I doubt that (c) is the right place because at position (c) the despill
> >> filter also affects the background video, which surely doesn't have any
> >> contamination from the bluescreen.
> >>
> > Then use it after colorkey.
>
> Is it possible to send zmq messages to the despill filter? I want to
> adjust the mix, expand and brightness parameters in real time. I'm
> sending the zmq messages from my own C# program. Messages to colorkey
> (color, similarity) and overlay (x, y) are already working. When I send
> messages to the despill filter, there is no error message but nothing
> changes in the output video. Either I have something wrong in my code,
> or the despill filter doesn't use the new values.
>

Nowhere is documented that despill have support for commands and thus it
does not have
support for commands.

>
> Michael
>
> _______________________________________________
> ffmpeg-user mailing list
> [hidden email]
> https://ffmpeg.org/mailman/listinfo/ffmpeg-user
>
> To unsubscribe, visit link above, or email
> [hidden email] with subject "unsubscribe".
_______________________________________________
ffmpeg-user mailing list
[hidden email]
https://ffmpeg.org/mailman/listinfo/ffmpeg-user

To unsubscribe, visit link above, or email
[hidden email] with subject "unsubscribe".
Reply | Threaded
Open this post in threaded view
|

Re: Best place for despill filter?

Michael Koch
Am 16.11.2020 um 20:01 schrieb Paul B Mahol:

>> Is it possible to send zmq messages to the despill filter? I want to
>> adjust the mix, expand and brightness parameters in real time. I'm
>> sending the zmq messages from my own C# program. Messages to colorkey
>> (color, similarity) and overlay (x, y) are already working. When I send
>> messages to the despill filter, there is no error message but nothing
>> changes in the output video. Either I have something wrong in my code,
>> or the despill filter doesn't use the new values.
>>
> Nowhere is documented that despill have support for commands and thus it
> does not have
> support for commands.

Oh, what a pity. We need more filters with support for commands. Now
that I have found out how to send zmq commands from C# code, there are
so many nice things that could be done with FFmpeg in real time.
Especially when adjusting parameters that need visual feedback, for
example brightness, contrast, gamma, color corrections, colorkey
parameters, despill parameters and so on...

Michael

_______________________________________________
ffmpeg-user mailing list
[hidden email]
https://ffmpeg.org/mailman/listinfo/ffmpeg-user

To unsubscribe, visit link above, or email
[hidden email] with subject "unsubscribe".
Reply | Threaded
Open this post in threaded view
|

Re: Best place for despill filter?

Moritz Barsnick
On Mon, Nov 16, 2020 at 20:15:54 +0100, Michael Koch wrote:
> Oh, what a pity. We need more filters with support for commands. Now
> that I have found out how to send zmq commands from C# code, there are
> so many nice things that could be done with FFmpeg in real time.
> Especially when adjusting parameters that need visual feedback, for
> example brightness, contrast, gamma, color corrections, colorkey
> parameters, despill parameters and so on...

Paul has worked heavily over the last few months to add command support
to filters (and to properly document it). I guess it just isn't trivial
in many cases, as the filters sometimes have not been designed with
runtime reconfiguration in mind. (Any it may not be possible at all in
certain cases.)

Cheers,
Moritz
_______________________________________________
ffmpeg-user mailing list
[hidden email]
https://ffmpeg.org/mailman/listinfo/ffmpeg-user

To unsubscribe, visit link above, or email
[hidden email] with subject "unsubscribe".
Reply | Threaded
Open this post in threaded view
|

Re: Best place for despill filter?

Michael Koch
Am 18.11.2020 um 14:40 schrieb Moritz Barsnick:

> On Mon, Nov 16, 2020 at 20:15:54 +0100, Michael Koch wrote:
>> Oh, what a pity. We need more filters with support for commands. Now
>> that I have found out how to send zmq commands from C# code, there are
>> so many nice things that could be done with FFmpeg in real time.
>> Especially when adjusting parameters that need visual feedback, for
>> example brightness, contrast, gamma, color corrections, colorkey
>> parameters, despill parameters and so on...
> Paul has worked heavily over the last few months to add command support
> to filters (and to properly document it). I guess it just isn't trivial
> in many cases, as the filters sometimes have not been designed with
> runtime reconfiguration in mind. (Any it may not be possible at all in
> certain cases.)
Yes, I know that Paul has added command support to many filters and I
really appreciate this work!
Paul, is it possible to add command support also for the despill filter?
I'm asking because I've written a C# tool for bluescreening in real
time. The foreground video comes from a camera via HDMI to USB converter
(these cheap chinese converters are great!). The background comes from a
file and is played in an endless loop. I have attached a screenshot. The
color bars are the built-in test image from the HDMI to USB converter.
All parameters can be adjusted with the scrollbars in real time and are
sent to the FFmpeg process as zmq messages. It's already running fine.
The only problem is that the despill parameters can't be updated in real
time. They become effective after stopping and re-starting FFmpeg (which
takes about 2 seconds).

If you want to see how this was programmed, have a look at chapter 2.56
of my book:
www.astro-electronic.de/FFmpeg_Book.pdf

Michael

_______________________________________________
ffmpeg-user mailing list
[hidden email]
https://ffmpeg.org/mailman/listinfo/ffmpeg-user

To unsubscribe, visit link above, or email
[hidden email] with subject "unsubscribe".

screenshot.jpg (135K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Best place for despill filter?

Paul B Mahol
Added commands to despill and frei0r filters.

On Wed, Nov 18, 2020 at 3:48 PM Michael Koch <[hidden email]>
wrote:

> Am 18.11.2020 um 14:40 schrieb Moritz Barsnick:
> > On Mon, Nov 16, 2020 at 20:15:54 +0100, Michael Koch wrote:
> >> Oh, what a pity. We need more filters with support for commands. Now
> >> that I have found out how to send zmq commands from C# code, there are
> >> so many nice things that could be done with FFmpeg in real time.
> >> Especially when adjusting parameters that need visual feedback, for
> >> example brightness, contrast, gamma, color corrections, colorkey
> >> parameters, despill parameters and so on...
> > Paul has worked heavily over the last few months to add command support
> > to filters (and to properly document it). I guess it just isn't trivial
> > in many cases, as the filters sometimes have not been designed with
> > runtime reconfiguration in mind. (Any it may not be possible at all in
> > certain cases.)
>
> Yes, I know that Paul has added command support to many filters and I
> really appreciate this work!
> Paul, is it possible to add command support also for the despill filter?
> I'm asking because I've written a C# tool for bluescreening in real
> time. The foreground video comes from a camera via HDMI to USB converter
> (these cheap chinese converters are great!). The background comes from a
> file and is played in an endless loop. I have attached a screenshot. The
> color bars are the built-in test image from the HDMI to USB converter.
> All parameters can be adjusted with the scrollbars in real time and are
> sent to the FFmpeg process as zmq messages. It's already running fine.
> The only problem is that the despill parameters can't be updated in real
> time. They become effective after stopping and re-starting FFmpeg (which
> takes about 2 seconds).
>
> If you want to see how this was programmed, have a look at chapter 2.56
> of my book:
> www.astro-electronic.de/FFmpeg_Book.pdf
>
> Michael
> _______________________________________________
> ffmpeg-user mailing list
> [hidden email]
> https://ffmpeg.org/mailman/listinfo/ffmpeg-user
>
> To unsubscribe, visit link above, or email
> [hidden email] with subject "unsubscribe".
_______________________________________________
ffmpeg-user mailing list
[hidden email]
https://ffmpeg.org/mailman/listinfo/ffmpeg-user

To unsubscribe, visit link above, or email
[hidden email] with subject "unsubscribe".
Reply | Threaded
Open this post in threaded view
|

Re: Best place for despill filter?

Michael Koch
Am 19.11.2020 um 13:19 schrieb Paul B Mahol:
> Added commands to despill and frei0r filters.

thank you! I'll test it in a few days when the Windows build is available.

Michael

_______________________________________________
ffmpeg-user mailing list
[hidden email]
https://ffmpeg.org/mailman/listinfo/ffmpeg-user

To unsubscribe, visit link above, or email
[hidden email] with subject "unsubscribe".